fix: Dev to main MACAE V3#691
Merged
Merged
Conversation
…ith default values
refactor: make virtual machine admin username and password optional with default values
fix: updated the echo to print to work with vscode web terminal
fix: logging issue fix
Dhruvkumar-Microsoft
requested review from
Avijit-Microsoft,
Fr4nc3,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft,
aniaroramsft,
dgp10801,
marktayl1,
nchandhi and
toherman-msft
as code owners
Roopan-Microsoft
approved these changes
Dec 8, 2025
Avijit-Microsoft
approved these changes
Dec 8, 2025
|
🎉 This PR is included in version 3.1.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request primarily refactors deployment scripts and infrastructure templates to improve maintainability, security, and clarity. The main changes include replacing
echowithprintffor more consistent output formatting in deployment scripts, updating how administrator credentials are handled for virtual machines, and adjusting logging environment variables for the backend and frontend deployments.Deployment script improvements:
echotoprintffor post-deployment messaging in bothazure.yamlandazure_custom.yaml, resulting in more consistent and readable output formatting. [1] [2]Infrastructure parameter and security updates:
virtualMachineAdminUsernameandvirtualMachineAdminPasswordparameters in bothinfra/main.bicepandinfra/main_custom.bicepfrom default-generated values to optional parameters, allowing explicit credential specification. [1] [2]Environment variable and logging configuration:
AZURE_BASIC_LOGGING_LEVEL,AZURE_PACKAGE_LOGGING_LEVEL,AZURE_LOGGING_PACKAGES) to the backend container app configuration for both standard and custom deployments, while removing them from the frontend/web site configuration to avoid redundancy. [1] [2] [3] [4]Python logging initialization:
logging.basicConfig(level=logging.INFO)initialization fromsrc/backend/common/utils/utils_kernel.pyto prevent unintended side effects and allow more controlled logging configuration elsewhere.Does this introduce a breaking change?
How to Test
What to Check
Verify that the following are valid
Other Information